Skip to content

feat: add money order feature for Davis lesson 17 with better organized code and all test passing #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

DavisD251
Copy link
Contributor

No description provided.

Copy link
Contributor

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this. I noticed the SourceAccount and TargetAccount classes, it's interesting that you created them, but I didn't see them being used or integrated elsewhere in the code. So consider that if you ever re-visit this assignment.

/** Represents a account. */
abstract class BankAccount {

protected static Set<Customer> owners = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks off, this member variable shouldn't be static and should not be set to null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants